]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
network: Don't destroy wireless dialog twice
authorFlorian Müllner <fmuellner@gnome.org>
Sat, 2 Mar 2019 19:46:28 +0000 (20:46 +0100)
committerFlorian Müllner <fmuellner@gnome.org>
Sat, 2 Mar 2019 21:09:20 +0000 (22:09 +0100)
The dialog doesn't change the `destroyOnClose` property from its default,
so it is already destroyed automatically on close. So if we also destroy
it explicitly, we end up (rightfully) with one of gjs' infamous "invalid
access" warnings.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/430

js/ui/status/network.js

index 21cbeac6127d7aff81930d847a712983ac1a1035..77a6202b8747d73dbcb744609b2223afe4ee19b0 100644 (file)
@@ -1236,7 +1236,6 @@ var NMDeviceWireless = class {
     }
 
     _dialogClosed() {
-        this._dialog.destroy();
         this._dialog = null;
     }